Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Per-session MFA for leaf apps #51394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Per-session MFA for leaf apps #51394

wants to merge 2 commits into from
+58 −17

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Jan 23, 2025 •
edited
Loading

MFA for app access in the WebUI mistakenly used the user's root client to check if mfa is required when connecting to a leaf app:

	// MFA verification should run in the cluster that holds the target resource.
	// If you are issuing challenges from the root cluster, but accessing a leaf,
	// call [AuthService.IsMFARequired] in the leaf instead of setting this field.
	MFARequiredCheck *IsMFARequiredRequest `protobuf:"bytes,5,opt,name=MFARequiredCheck,proto3" json:"mfa_required_check,omitempty"`

Fixes #51350

Changelog: Fix connecting to Apps in a leaf cluster when Per-session MFA is enabled.

@Joerger Joerger force-pushed the joerger/fix-mfa-leaf-app branch 2 times, most recently from f4ac8f6 to fa93b48 Compare January 23, 2025 20:09
@Joerger Joerger marked this pull request as ready for review January 23, 2025 20:09
@Joerger Joerger force-pushed the joerger/fix-mfa-leaf-app branch from fa93b48 to add9cc9 Compare January 23, 2025 20:10
@Joerger Joerger force-pushed the joerger/fix-mfa-leaf-app branch from add9cc9 to 9ca5eae Compare January 23, 2025 22:31
@Joerger Joerger force-pushed the joerger/fix-mfa-leaf-app branch from 9ca5eae to e2d0ae8 Compare January 23, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyinghermit flyinghermit Awaiting requested review from flyinghermit

@ravicious ravicious Awaiting requested review from ravicious

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport/branch/v16 backport/branch/v17 size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App MFA disable keeps failing MFA challenge
1 participant
@Joerger